Added support for multiple objectClasses to be set on the EntityMap. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I keep your PR in mind. |
|
Thanks, I do think it needs more testing with various LDAP configurations (I've only tested it with our company's active directory). Happy to work on it more if you have an feedback or input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a user extends EntityMap and sets, amongst other things, $this->ldap_object_class which expects a string. I am not sure how common it is but in our active directory we have multiple objectClasses and when it came to adding a new user, I needed to set a number of objectClasses for the operation to complete successfully.
This pull request preserves existing functionality in that a user can still set $this->ldap_object_class with a string value but also allows a user to set an array of objectClasses if they so wish.