fix: Ensure ingestor image uses the latest cryoet-data-portal-neuroglancer main branch #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uermel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to
chanzuckerberg/cryoet-data-portal-neuroglancer#17
Description
Poetry stores the commit ID that was pulled whenever the lock file is created. We want to use the most recent version of the
cryoet-data-portal-neuroglancermain branch, so we should explicitely update the dependency when building the image. The alternative is to hardcode a specific commit in a non-codegen'ed place (i.e. the pyproject.toml), so it's more obvious.