fix: add content type to metadata file #425
Merged
+45
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloster
force-pushed
the
kaloster/content-type-open
branch
from
daa57df to
90d78f6
Compare
jgadling
reviewed
Jan 23, 2025
|
Is it practical to write some tests for this, to make sure that we set content type properly for json files, and also that content types for images aren't weird? |
jgadling
reviewed
Jan 24, 2025
ingestion_tools/scripts/tests/s3_import/test_collection_metadata.py
Outdated
Show resolved
Hide resolved
kaloster
force-pushed
the
kaloster/content-type-open
branch
from
319e75f to
a440649
Compare
jgadling
approved these changes
Jan 24, 2025
manasaV3
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to chanzuckerberg/cryoet-data-portal#1390
Description
This one makes sure that
ContentTypeis set only for metadata json filesTested here and here.