feat: Update to generic annotation transformation callout during down…

…load (#1186) #1005 #1045 #1046 This change is being made because we are no longer providing specific transformation code when annotations are used with non-standard tomograms. This also adds a 15 second `sleep` before running tests so that the app server has time to start (`ERR_CONNECTION_REFUSED`).
chanzuckerberg · Sep 30, 2024 · 5597524 · 5597524
1 parent 1732fb2
commit 5597524
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/.github/workflows/frontend-e2e-tests.yml b/.github/workflows/frontend-e2e-tests.yml
@@ -159,7 +159,9 @@ jobs:
           ENV: ${{ inputs.environment }}
 
       - name: Run E2E tests
-        run: pnpm e2e --shard ${{ matrix.shardCurrent }}/${{ matrix.shardTotal }}
+        run: |
+          sleep 15
+          pnpm e2e --shard ${{ matrix.shardCurrent }}/${{ matrix.shardTotal }}
         working-directory: frontend/packages/data-portal
         env:
           API_URL: ${{ vars.API_URL }}

diff --git a/frontend/packages/data-portal/app/components/Download/ConfigureTomogramDownloadContent.tsx b/frontend/packages/data-portal/app/components/Download/ConfigureTomogramDownloadContent.tsx
@@ -173,7 +173,11 @@ export function ConfigureTomogramDownloadContent() {
       </RadioGroup>
 
       {runId && (
-        <Callout className="!w-full !mt-sds-xl" intent="info" expandable>
+        <Callout
+          className="!w-full !mt-sds-xl !mb-sds-xxs"
+          intent="info"
+          expandable
+        >
           <CalloutTitle>
             <p className="text-sds-body-xs leading-sds-body-xs">
               <I18n i18nKey="downloadAllRunData" />
@@ -197,7 +201,7 @@ export function ConfigureTomogramDownloadContent() {
 
       {multipleTomogramsEnabled && (
         <Callout intent="notice" className="!w-full !mt-0">
-          {t('annotationsDownloadedFromThePortal')}
+          {t('annotationsMayRequireTransformation')}
         </Callout>
       )}
     </>

diff --git a/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx b/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx
@@ -168,8 +168,8 @@ export function DownloadOptionsContent() {
       <DownloadTabContent />
 
       {multipleTomogramsEnabled && (
-        <Callout intent="notice" className="!w-full">
-          {t('annotationsDownloadedFromThePortal')}
+        <Callout intent="notice" className="!w-full !mt-sds-xl">
+          {t('annotationsMayRequireTransformation')}
         </Callout>
       )}
     </>

diff --git a/frontend/packages/data-portal/public/locales/en/translation.json b/frontend/packages/data-portal/public/locales/en/translation.json
@@ -30,14 +30,14 @@
   "annotationConfidence": "Annotation Confidence",
   "annotationDetails": "Annotation Details",
   "annotationId": "Annotation ID",
+  "annotationsMayRequireTransformation": "Annotations may require transformation if the desired tomogram has a different Alignment ID.",
   "annotationMetadata": "Annotation Metadata",
   "annotationMethod": "Annotation Method",
   "annotationMethodsSummary": "Annotation Methods Summary",
   "annotationObject": "Annotation Object",
   "annotationOverview": "Annotation Overview",
   "annotationSoftware": "Annotation Software",
   "annotations": "Annotations",
-  "annotationsDownloadedFromThePortal": "Annotations downloaded from the portal may require transformation to work with the selected tomogram.",
   "annotationsSummary": "Annotations Summary",
   "annotationsTotal": "Annotations (Total)",
   "api": "API",