Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single dataset key photo #117

Merged
merged 1 commit into from
Nov 2, 2023
Merged

add single dataset key photo #117

merged 1 commit into from
Nov 2, 2023

Conversation

kne42
Copy link
Member

@kne42 kne42 commented Oct 31, 2023

Implemented as in #31. Adds the dataset level key photo. Note: actual key photo not available from database yet. Contains CSS code which does not run on IE (which when synced with @codemonkey800 is not a browser we support anyways).

dataset-key-photo.mov

@codemonkey800
Copy link
Contributor

hmm you might need to rebase from main and remove my commits:

image

@kne42
Copy link
Member Author

kne42 commented Oct 31, 2023

hmm you might need to rebase from main and remove my commits:

image

yeah i just had to force-push my other branch; updated this one as well

@kne42 kne42 force-pushed the kira/single-dataset-key-photo branch 2 times, most recently from caf4bb3 to 78eedc1 Compare November 1, 2023 23:39
Base automatically changed from kira/single-dataset-description to main November 2, 2023 20:10
@kne42 kne42 marked this pull request as ready for review November 2, 2023 20:10
@kne42 kne42 force-pushed the kira/single-dataset-key-photo branch from 78eedc1 to 6d902ee Compare November 2, 2023 20:12
@kne42 kne42 merged commit 54df7d1 into main Nov 2, 2023
2 of 3 checks passed
@kne42 kne42 deleted the kira/single-dataset-key-photo branch November 2, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants