Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run page header #119

Merged
merged 18 commits into from
Nov 10, 2023
Merged

run page header #119

merged 18 commits into from
Nov 10, 2023

Conversation

codemonkey800
Copy link
Contributor

Description

Implements the single run page header. This refactors the code to reuse the same page header code from the single dataset page. This also sets up the initial query for fetching a run by ID.

Demo

image

Next Steps

  • Add data for frames

frontend/packages/data-portal/app/i18n.ts Outdated Show resolved Hide resolved
frontend/packages/data-portal/app/i18n.ts Outdated Show resolved Hide resolved

export function useDatasetDrawer() {
const [open, setOpen] = useAtom(datasetDrawerOpenAtom)
export function useDrawer() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad we had the same idea yippie! (maybe I am doing things right!)

@codemonkey800 codemonkey800 merged commit 29cda59 into main Nov 10, 2023
3 checks passed
@codemonkey800 codemonkey800 deleted the jeremy/run-page-header branch November 10, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants