Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run page annotations table #123

Merged
merged 9 commits into from
Nov 10, 2023
Merged

run page annotations table #123

merged 9 commits into from
Nov 10, 2023

Conversation

codemonkey800
Copy link
Contributor

@codemonkey800 codemonkey800 commented Nov 6, 2023 •
edited
Loading

#45

  • Extracts page layout into generic component used for all pages with tables
  • Update GraphQL config to convert numeric to number in TypeScript
  • Add cnsNoMerge util
  • Add alignment prop to TableCell compoennt
  • Implement AnnotationTable component
  • Integration AnnotationTable component with single run page

Demo

image

Base automatically changed from jeremy/run-page-header to main November 10, 2023 05:08
@codemonkey800 codemonkey800 force-pushed the jeremy/run-page-annotations-table branch from 0914a56 to eb3e5ee Compare November 10, 2023 05:35
@codemonkey800
Copy link
Contributor Author

going to merge this PR, we can address any feedback later during the bug bash

@codemonkey800 codemonkey800 merged commit 8c9f9a4 into main Nov 10, 2023
3 checks passed
@codemonkey800 codemonkey800 deleted the jeremy/run-page-annotations-table branch November 10, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manasaV3 manasaV3 Awaiting requested review from manasaV3

@kne42 kne42 Awaiting requested review from kne42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codemonkey800