Adding github workflows for deploy #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 7 7
Lines 503 503
=======================================
Hits 395 395
Misses 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
codemonkey800
approved these changes
Oct 16, 2023
Comment on lines
+1
to
+4
| on: | ||
| push: | ||
| branches: | ||
| - "main" |
There was a problem hiding this comment.
are we always going to push main to prod?
There was a problem hiding this comment.
Yeah, we will deploy to prod on every push for the moment.
jgadling
reviewed
Oct 16, 2023
| aws-region: ${{ secrets.AWS_REGION }} | ||
| role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }} | ||
| role-duration-seconds: 1200 | ||
| - name: Login to ECR |
There was a problem hiding this comment.
I don't think we need to do this step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #51
Adds deployment to dev, staging, and prod environments.