[feature] Add GitHub Webhooks archiver and S3 private bucket modules #112
Conversation
.idea/.gitignore
Outdated
| @@ -0,0 +1,3 @@ | |||
|
|
|||
There was a problem hiding this comment.
we should probably add .idea to the top level .gitignore and not check in any of the files in this directory
github-webhooks-to-s3/Makefile
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Auto-generated by fogg. Do not edit | |||
There was a problem hiding this comment.
this Makefile is not valid in this context, can be rm'd
| @@ -0,0 +1,102 @@ | |||
| module "bucket" { | |||
| source = "../aws-s3-private-bucket" | |||
There was a problem hiding this comment.
this path is not valid here, we might also have to opensource this module as well
| variable "lambda_source_s3_bucket" { | ||
| type = "string" | ||
| description = "The s3 bucket where to find the lambda executable" | ||
| default = "shared-infra-prod-assets" |
There was a problem hiding this comment.
TODO @edulop91 check this bucket
There was a problem hiding this comment.
Were you able to check this bucket?
There was a problem hiding this comment.
yeah! i'm working on moving some of this data to a new public bucket
| @@ -0,0 +1,23 @@ | |||
| <!-- START --> | |||
There was a problem hiding this comment.
Might also be valuable to write a short description of what this is and an example of how to use it
.gitignore
Outdated
| bin | ||
| .idea |
There was a problem hiding this comment.
👌
we should also rm the already checked-in .idea directory
aws-s3-private-bucket/Makefile
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Auto-generated by fogg. Do not edit | |||
aws-s3-private-bucket/main.tf
Outdated
| } | ||
|
|
||
| resource "aws_s3_bucket_public_access_block" "bucket" { | ||
| bucket = "${aws_s3_bucket.bucket}" |
There was a problem hiding this comment.
you might have to do aws_s3_bucket.bucket.id https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#id-2
aws-s3-private-bucket/outputs.tf
Outdated
| @@ -0,0 +1,16 @@ | |||
| // HACK(el): we do this to hint TF dependency graph since modules can't depend_on | |||
| output "name" { | |||
| value = "${var.bucket_name}" | |||
There was a problem hiding this comment.
we should probably make this aws_s3_bucket.bucket.id
edulop91
changed the title
No description provided.