Support multiple services in params reader policy #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the params-reader-policy to support multiple services for the params prefixes it can read. It uses the existing project-env-service pattern, but also allows users to specify other services, as long as those services also share the same project and env, i.e. project-env-service2, project-env-service3.
Instead of instantiating the params reader multiple times and thus adding multiple IAM policy attachment, this allows us to keep it all in a single IAM policy which keeps us from hitting the IAM policy count limit. Should be backwards compatible with existing usage. This is needed for a particular use case where one team is spreading their SSM parameters across multiple names.