Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws-ecs-* task execution role permissions #133

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Fix aws-ecs-* task execution role permissions #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion aws-ecs-job-fargate/iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ resource "aws_iam_role" "task_execution_role" {
# the specific ECR arn if applicable, and the specific cloudwatch log group.
# Either pass both identifiers in, or pass the entire role ARN as an argument
resource "aws_iam_role_policy_attachment" "task_execution_role" {
count = var.registry_secretsmanager_arn != null ? 1 : 0
role = aws_iam_role.task_execution_role.name
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
}
Expand Down
1 change: 0 additions & 1 deletion aws-ecs-service-fargate/iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ resource "aws_iam_role" "task_execution_role" {
# TODO: Add support for giving permissions to ECR ARNs and possibly cloudwatch log group
# Or provide ability to pass in own execution role ARN
resource "aws_iam_role_policy_attachment" "task_execution_role" {
count = var.registry_secretsmanager_arn != null ? 1 : 0
role = aws_iam_role.task_execution_role.name
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
}
Expand Down