aws-acm-cert Add workaround for TF bug #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edulop91
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for the user to specify the specific order they want for the certificate subject alternative names at a particular time applying. Unfortunately this cannot be a permanent workaround because of hashicorp/terraform-provider-aws#8531, meaning AWS will change the order arbitrarily on their own discretion although the order seems stable within short periods of time allowing the workaround to work. Because of this constantly changing order, just changing the type of cert_subject_alternative_names to a type that allows specifying ordering won't help. This workaround is only needed when the user starts providing more than 1 SAN for a cert.
In most cases, the user can omit this argument, but can possibly set a temporary one time value locally if only to get their PR to go through cleanly one time. Hopefully when Terraform or AWS fixes its bug, we won't need to change the module or its interface to support the fixed value.