Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slow_start parameter to ecs-service-with-alb #151

Merged
merged 1 commit into from
Oct 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws-ecs-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ service = false` argument can be removed.
| registry\_secretsmanager\_arn | ARN for AWS Secrets Manager secret for credentials to private registry | string | `null` | no |
| route53\_zone\_id | Zone in which to create an alias record to the ALB. | string | n/a | yes |
| service | Service for tagging and naming. See [doc](../README.md#consistent-tagging). | string | n/a | yes |
| slow_start | Seconds for targets to warm up before the load balancer sends them a full share of requests. | number | 60 | no |
| ssl\_policy | ELB policy to determine which SSL/TLS encryption protocols are enabled. Probably don't touch this. | string | `null` | no |
| subdomain | Subdomain in the zone. Final domain name will be subdomain.zone | string | n/a | yes |
| tag\_service | Apply cost tags to the ECS service. Only specify false for backwards compatibility with old ECS services. | bool | `true` | no |
Expand Down
1 change: 1 addition & 0 deletions aws-ecs-service/alb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ resource "aws_lb_target_group" "service" {
target_type = var.awsvpc_network_mode ? "ip" : "instance"

deregistration_delay = 60
slow_start = var.slow_start

health_check {
path = var.health_check_path
Expand Down
6 changes: 6 additions & 0 deletions aws-ecs-service/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -196,3 +196,9 @@ variable "ordered_placement_strategy" {
default = []
description = "Placement strategy for the task instances."
}

variable "slow_start" {
description = "Seconds for targets to warm up before the load balancer sends them a full share of requests. 30-900 seconds or 0 to disable."
type = number
default = 60
}