Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include image-source-role-arn input for deploy happy #228

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: include image-source-role-arn input for deploy happy #228

merged 1 commit into from
Oct 27, 2023

Conversation

shitchcock
Copy link
Contributor

I believe I'll need this full syntax for my actions to work as per @alexlokshin-czi 's comment here

happy update STAGING_STACK_NAME --env staging --image-src-env rdev --image-src-stack rdev_STACK_NAME --image-src-role-arn "arn:aws:iam::ACCOUNT:role/<rdev-role>"

jakeyheath
jakeyheath approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jakeyheath jakeyheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're a boss

@shitchcock shitchcock merged commit 4168f8c into main Oct 27, 2023
9 checks passed
@shitchcock shitchcock deleted the shitchcock-role-arn branch October 27, 2023 18:29
@czi-github-helper czi-github-helper bot mentioned this pull request Oct 27, 2023
Merged
@jfoo1984 jfoo1984 mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakeyheath jakeyheath jakeyheath approved these changes

@jfoo1984 jfoo1984 jfoo1984 approved these changes

@alexlokshin-czi alexlokshin-czi Awaiting requested review from alexlokshin-czi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shitchcock @jfoo1984 @jakeyheath