Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add working-dir to happy cleanup #262

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

shitchcock
Copy link
Contributor

Adding working directory option for the monorepo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shitchcock shitchcock requested a review from jakeyheath April 30, 2024 18:27
@shitchcock shitchcock changed the title [feat] add working-dir to happy cleanup feat: add working-dir to happy cleanup Apr 30, 2024
@shitchcock shitchcock requested a review from timzchang April 30, 2024 18:44
Comment on lines +18 to +21
working_directory:
description: "The happy project root"
default: "."
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to add this var to install-happy and pass it through in this action so it knows where to find the .happy/version.lock

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shitchcock did you see this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we would need to add it to install-happy when the input var works fine in deploy-happy-stack? Which uses install happy in a similar fashion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine for now since the edu version of the happy cleanup script has the version hard coded in their action. Generally, we should try to grab the project's version so they match using this input: https://github.com/chanzuckerberg/github-actions/blob/main/.github/actions/install-happy/action.yaml#L20C2-L20C21. But maybe we can cut a new PR for that feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using deploy without having to declare a version lock file. Should we update our callsites?

https://github.com/chanzuckerberg/bento/blob/main/.github/workflows/deploy.yml#L184-L194

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For projects not using version lock it will work as expected but if someone uses a version lock in a nested directory the install-happy action won't know which version of happy to install and will default to latest

@shitchcock shitchcock force-pushed the shitchcock-add-dir branch from cae6029 to ea0b3a1 Compare May 1, 2024 20:25
jakeyheath
jakeyheath previously approved these changes May 1, 2024
@jakeyheath jakeyheath dismissed their stale review May 2, 2024 17:57

See Hayden's comments

@jakeyheath jakeyheath self-requested a review May 6, 2024 20:06
@shitchcock shitchcock merged commit ddd2721 into main May 6, 2024
9 checks passed
@shitchcock shitchcock deleted the shitchcock-add-dir branch May 6, 2024 20:13
@czi-github-helper czi-github-helper bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants