-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add working-dir to happy cleanup #262
Conversation
working_directory: | ||
description: "The happy project root" | ||
default: "." | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also want to add this var to install-happy
and pass it through in this action so it knows where to find the .happy/version.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shitchcock did you see this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we would need to add it to install-happy
when the input var works fine in deploy-happy-stack? Which uses install happy in a similar fashion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine for now since the edu version of the happy cleanup script has the version hard coded in their action. Generally, we should try to grab the project's version so they match using this input: https://github.com/chanzuckerberg/github-actions/blob/main/.github/actions/install-happy/action.yaml#L20C2-L20C21. But maybe we can cut a new PR for that feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using deploy without having to declare a version lock file. Should we update our callsites?
https://github.com/chanzuckerberg/bento/blob/main/.github/workflows/deploy.yml#L184-L194
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For projects not using version lock it will work as expected but if someone uses a version lock in a nested directory the install-happy action won't know which version of happy to install and will default to latest
cae6029
to
ea0b3a1
Compare
Adding working directory option for the monorepo