feat: Add secret_files arg to Argus docker builder to allow passing files to build context #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspitzley-czi
requested review from
jakeyheath,
alexlokshin-czi and
naihsuanshao
alexlokshin-czi
approved these changes
Aug 16, 2024
hspitzley-czi
deleted the
CCIE-3254-add-secret-files-arg-to-argus-docker-builder-to-allow-passing-files-to-build-context
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support building Dockerfiles that use private github package registries. Eg: we need to be able to pass the .npmrc to the docker build context for eng-portal to install the happy-api & PEP npm dependencies