fix: prevent manifest update after another commit #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeyheath
approved these changes
Sep 23, 2024
hspitzley-czi
deleted the
hspitzley/prevent_manifest_update_after_another_commit
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update to this builder action to support triggering it from a
pull_requesttrigger involved a change to the checkout action that caused some issues. In the image below, the commits from the builder are dependent on how long it takes to build, meaning sometimes a prior build that took longer to build would overwrite a more recent build that had already committed back to the values yaml.This issue arose because the checkout action started receiving a
refargument that would be set to the branch name in the case of apushevent, this caused the job to checkout the latest from the branch and then push over whatever was already there. Not supplying theref, or setting it to an empty string, causes the checkout action to fetch at the point that the workflow was triggered, which in turn causes the commit of the build sha to fail if a newer commit has updated the build sha since the job was initially invoked.