fix: only get stack info on delete if deleting images (#2937)

* fix: only get stack info on delete if deleting images * commit from cli-ci -- updated coverage * revert mod * commit from cli-ci -- updated coverage --------- Co-authored-by: jakeyheath <[email protected]>
chanzuckerberg · Jan 9, 2024 · e684dbe · e684dbe
1 parent ca30025
commit e684dbe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/cli/COVERAGE b/cli/COVERAGE
@@ -1 +1 @@
-20.82
+20.81
diff --git a/cli/cmd/delete.go b/cli/cmd/delete.go
@@ -108,17 +108,17 @@ func runDelete(cmd *cobra.Command, stackName string) error {
 		}
 	}
 
-	stackInfo, err := stack.GetStackInfo(ctx)
-	if err != nil {
-		return errors.Wrap(err, "unable to get stack info")
-	}
-
 	// Delete the current ECR images if autocreate is not enabled
 	if !happyClient.HappyConfig.GetFeatures().EnableECRAutoCreation {
-		log.Debug("Deleting stack images")
-		err = happyClient.ArtifactBuilder.DeleteImages(ctx, stackInfo.StackMetadata.Tag)
+		stackInfo, err := stack.GetStackInfo(ctx)
 		if err != nil {
-			log.Error("Failed to delete stack images, please delete them manually")
+			log.Errorf("%s: unable to get stack info", err)
+		} else {
+			log.Debug("Deleting stack images")
+			err = happyClient.ArtifactBuilder.DeleteImages(ctx, stackInfo.StackMetadata.Tag)
+			if err != nil {
+				log.Error("Failed to delete stack images, please delete them manually")
+			}
 		}
 	}