fix: if one oidc verifier is failing, do not let the whole API fail #3769
Conversation
kuannie1
requested review from
alldoami,
jakeyheath and
hspitzley-czi
and removed request for
a team and
alldoami
|
No Jira issue reference found in branch, title, or body of PR. Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR. |
| continue | ||
| } | ||
| verifiers = append(verifiers, verifier) | ||
| } | ||
| if len(verifiers) == 1 { |
There was a problem hiding this comment.
fail if zero, and print the number of verifiers otherwise
There was a problem hiding this comment.
why should we fail if zero if you initialize it with one already?
There was a problem hiding this comment.
hmm yea I guess that is fine. If none of the OIDC providers configure then no one can talk to it except for Github actions. I guess that is fine. Send it!
There was a problem hiding this comment.
I kept the == 1 part, but I added an Infof message to print the # of OIDC verifiers. Hopefully that works!
|
No Jira issue reference found in branch, title, or body of PR. Please add a reference to a Jira issue in the form of CCIE-#### (eg: CCIE-1400) to the branch name, title, or body of your PR. |
CCIE-3867
Sometimes there's an OIDC configuration that doesn't work, but we shouldn't make the entire Happy API fail because of that. In this change, we spit out a warning and an additional warning if there's only one verifier.
https://czi.atlassian.net/browse/CCIE-3867