Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling non github source code #1101

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Handling non github source code #1101

merged 3 commits into from
Jun 13, 2023

Conversation

manasaV3
Copy link
Collaborator

@manasaV3 manasaV3 commented Jun 9, 2023 •
edited
Loading

Description

Relates to: #1105

The PR introduces fixes for the following:

  • Does not process for github metadata if the code repository does not match the prefix expected for github
  • Gracefully handles json parsing error when fetching license data from github.

@manasaV3 manasaV3 added the bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes label Jun 9, 2023
@manasaV3 manasaV3 marked this pull request as ready for review June 9, 2023 21:11
aganders3
aganders3 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@aganders3 aganders3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

backend/api/model.py Show resolved Hide resolved
backend/utils/github.py Show resolved Hide resolved
backend/utils/github.py Outdated Show resolved Hide resolved
@manasaV3 manasaV3 merged commit 9d7843e into main Jun 13, 2023
@manasaV3 manasaV3 deleted the multireg-bf branch June 13, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemonkey800 codemonkey800 codemonkey800 approved these changes

@aganders3 aganders3 aganders3 approved these changes

@kne42 kne42 Awaiting requested review from kne42

Assignees
No one assigned
Labels
bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manasaV3 @aganders3 @codemonkey800