Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable signup footer #1317

Merged
merged 2 commits into from
May 29, 2024
Merged

disable signup footer #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f09b7
disable signup footer
codemonkey800 May 29, 2024
b285aa4
update snapshots
codemonkey800 May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/HomePage/HomePageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { ReactNode } from 'react';
import { AppBarLanding } from '@/components/AppBar';
import { Banner } from '@/components/Banner';
import { Footer } from '@/components/Footer';
import { SignupForm } from '@/components/SignupForm';

interface Props {
children: ReactNode;
Expand All @@ -15,7 +14,8 @@ export function HomePageLayout({ children }: Props) {
<Banner />
<AppBarLanding />
<div className="flex-grow min-h-screen">{children}</div>
<SignupForm variant="home" />
{/* Disabling for now because HubSpot drops cookies */}
{/* <SignupForm variant="home" /> */}
<Footer />
</div>
);
Expand Down
9 changes: 4 additions & 5 deletions frontend/src/components/Layout/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,25 @@
import { useRouter } from 'next/router';
import { ReactNode } from 'react';

import { AppBar } from '@/components/AppBar';
import { Banner } from '@/components/Banner';
import { Footer } from '@/components/Footer';
import { SignupForm } from '@/components/SignupForm';

interface Props {
children: ReactNode;
}

export function Layout({ children }: Props) {
const router = useRouter();
const isSearchPage = router.pathname === '/plugins';
// const router = useRouter();
// const isSearchPage = router.pathname === '/plugins';

return (
<div className="flex flex-col min-h-screen">
<Banner />
<AppBar />

<main className="flex flex-col flex-grow">{children}</main>
<SignupForm variant={isSearchPage ? 'search' : 'default'} />
{/* Disabling for now because HubSpot drops cookies */}
{/* <SignupForm variant={isSearchPage ? 'search' : 'default'} /> */}
<Footer />
</div>
);
Expand Down
54 changes: 0 additions & 54 deletions frontend/src/components/Layout/__snapshots__/Layout.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,60 +138,6 @@ exports[`<Layout /> should match snapshot 1`] = `
Hello, World!
</h1>
</main>
<div
class="bg-hub-primary-200 p-sds-xl screen-495:p-12 grid justify-center gap-sds-xl screen-495:gap-12 grid-cols-2 screen-875:grid-cols-napari-3 screen-1150:grid-cols-napari-4 screen-1425:grid-cols-napari-5"
>
<div
class="hidden"
id="hubspot-form-container"
/>
<div
class="col-span-2 screen-495:col-span-3 screen-1425:col-start-2"
>
<h2
class="text-lg font-semibold mb-sds-xxs screen-495:mb-sds-l"
>
Sign up to receive updates
</h2>
<form
class="grid grid-cols-2 screen-875:grid-cols-napari-3 screen-495:gap-x-12 gap-y-sds-l"
novalidate=""
>
<div
aria-label="Email address"
class="MuiFormControl-root MuiTextField-root text-sds-body-s pt-sds-xxxs h-8 screen-495:h-[35px] col-span-2 screen-495:col-span-1 screen-875:col-span-2 css-1u3bzj6-MuiFormControl-root-MuiTextField-root"
>
<div
class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-colorPrimary MuiInputBase-formControl css-1ptx2yq-MuiInputBase-root-MuiInput-root"
>
<input
aria-invalid="false"
class="MuiInputBase-input MuiInput-input css-1x51dt5-MuiInputBase-input-MuiInput-input"
data-testid="emailField"
id=":r0:"
name="EMAIL"
placeholder="email"
required=""
type="email"
value=""
/>
</div>
</div>
<button
class="MuiButtonBase-root MuiButton-root MuiButton-contained MuiButton-containedPrimary MuiButton-sizeMedium MuiButton-containedSizeMedium MuiButton-disableElevation MuiButton-root MuiButton-contained MuiButton-containedPrimary MuiButton-sizeMedium MuiButton-containedSizeMedium MuiButton-disableElevation bg-hub-primary-400 hover:bg-hub-primary-500 active:bg-hub-primary-600 text-sds-body-s font-semibold text-black h-[35px] col-span-2 screen-495:col-span-1 css-1k16prx-MuiButtonBase-root-MuiButton-root"
data-testid="submitButton"
name="subscribe"
tabindex="0"
type="submit"
>
Subscribe
<span
class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root"
/>
</button>
</form>
</div>
</div>
<div
class="grid grid-cols-2 screen-655:grid-cols-[1fr,min-content] screen-1150:grid-cols-[1fr,max-content,min-content] gap-sds-l bg-hub-primary-400 p-sds-xl screen-495:px-12"
>
Expand Down
Loading