Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npe2api instead of scraping PyPI for active plugins #1331

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

aganders3
Copy link
Contributor

Description

Recent changes to the PyPI website to prevent scraping search results have...prevented us from scraping search results.

npe2api faced the same issue but also uses the public BigQuery PyPI metadata database as a source of truth for active plugins (with the Framework::napari trove classifier). This means the index is only updated every 2h (could possibly be reduced to 1h), but it's a more robust and future-proof solution.

I believe relying on npe2api (https://api.napari.org) as a source of truth is reasonable given the plan to move napari-hub to community support.

Related

napari/npe2api#35
napari/npe2api#37
napari/npe2api#41
napari Zulip Thread
PyPI Discussion

@aganders3 aganders3 added the bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes label Jan 7, 2025
@aganders3 aganders3 requested a review from manasaV3 January 7, 2025 17:38
@aganders3 aganders3 added the cicd Release Label: Used for categorizing CICD changes in automated CI release notes label Jan 7, 2025
@aganders3
Copy link
Contributor Author

I reverted ea2562d here and moved it into #1332. Checks will fail on this branch until that is merged and we can rebase.

@aganders3 aganders3 removed the cicd Release Label: Used for categorizing CICD changes in automated CI release notes label Jan 13, 2025
Copy link
Collaborator

@manasaV3 manasaV3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aganders3 aganders3 force-pushed the fix-broken-scraping branch 2 times, most recently from 836b04d to cdd4c98 Compare January 13, 2025 20:44
@aganders3 aganders3 merged commit 859ffb8 into main Jan 13, 2025
9 checks passed
@aganders3 aganders3 deleted the fix-broken-scraping branch January 13, 2025 21:02
Copy link

This PR has been included in release: v25.01.0, see the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Release Label: Used for categorizing bug fixes in automated CI release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants