Lighthouse score improvements #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemonkey800
added
the
improvement
klai95
reviewed
Mar 16, 2023
| @@ -15,8 +15,6 @@ exports[`<PluginComplexFilter /> should match snapshot 1`] = ` | |||
| <button | |||
| class="MuiButtonBase-root MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium text-black w-full flex justify-between p-0 pb-2 css-1kjmhix-MuiButtonBase-root-MuiButton-root" | |||
| data-testid="button" | |||
| label="pluginData:labels.operatingSystem" | |||
There was a problem hiding this comment.
Why did we remove this part?
There was a problem hiding this comment.
we've been getting errors on the home page saying that we can't pass the sdsStage prop to native DOM elements, so this is fixed in this commit: 73cb567
As a result, some other props aren't being passed like label, but that's fine because we don't want to pass those props to the <button> element anyway
klai95
approved these changes
Mar 16, 2023
manasaV3
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#898
Improves Lighthouse scoress. This includes various changes such as:
ultodivto fix descendant errorsaria-labelprops to buttons and linksh1-h6Unfortunately, this only impacts Accessibility scores. To improve the best practices score, we'll need to enable source maps in production which is not working with our current version of Next.js. SEO scores are pretty good for most pages, the only thing we need to do is improve the font size for collection pages. All follow up work is listed below or in #898 (comment)
Demos
Home Page
Before
After
Plugin Page
Before
After
Collection Index Page
Before
After
Collection Page
Before
After
Markdown Pages
Before
After
Follow ups
Opened follow up issues found during profiling: