Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ButtonDropdown): Sync Button props type #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ButtonDropdown): Sync Button props type #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/components/src/core/ButtonDropdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ButtonProps as RawButtonProps } from "@mui/material";
import React, { ForwardedRef } from "react";
import Button from "src/core/Button";
import Button, { ButtonProps } from "src/core/Button";
import Icon, { IconNameToSizes, IconProps } from "src/core/Icon";
import ButtonIcon from "../ButtonIcon";
import {
Expand All @@ -10,8 +10,8 @@ import {

type SdsProps = {
icon?: keyof IconNameToSizes | React.ReactElement<CustomSVGProps>;
sdsStyle?: "rounded" | "square" | "icon";
sdsType?: "primary" | "secondary";
sdsStyle?: ButtonProps['sdsStyle'];
sdsType?: ButtonProps['sdsType'];
sdsIconProps?: Partial<IconProps<keyof IconNameToSizes>>;
sdsSize?: "small" | "medium" | "large";
};
Expand Down