Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin COG to < 2 #7414

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: pin COG to < 2 #7414

wants to merge 2 commits into from

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Jan 24, 2025

Reason for Change

updates all of the COG versions in data portal to <2, and specifies the schema version in the OntologyParser as 5.2.0. this means we'll fetch the latest version of COG that's compliant with 5.2.0.

when we bump the schema version in the future, we'll need to bump the version specified in OntologyParser. i've added this to step 10 in the confluence page

Testing steps

let's see what happens with the unit tests

Checklist 🛎️

  • Add product, design, and eng as reviewers for rdev review
  • For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
  • For UI changes, add e2e tests to prevent regressions
  • For UI changes, verify impacted analytics events still work

not applicable here

Notes for Reviewer

@joyceyan joyceyan requested review from Bento007 and kaloster January 24, 2025 00:09
Copy link
Contributor

Deployment Summary

Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the ontologyparser is initiated in various spots w/o a version arg https://github.com/search?q=repo%3Achanzuckerberg%2Fsingle-cell-data-portal%20ontologyparser&type=code

this means they'll default to the latest schema version; in 1.3.1, that's 5.3.0 (which is not released yet). You should pass in 5.2.0 as an arg for all the OntologyParsers and then just shift all these to cellxgene-ontology-guide<2

@joyceyan joyceyan changed the title chore: pin COG to 1.3.1 chore: pin COG to < 2 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants