[WIP] Fix for issue 52

[nomaster]

The current use of the 'id' column to store barcode values is exotic at best and leads to several issues. I found no other solution than to re-create the table.

Also, I implemented the one-to-one relation of drink and barcode properly.

Barcode data will be lost upon migration, but I guess we can live with that.

Fixes #52

[msteinhoff]

The current use of the 'id' column to store barcode values is exotic at best

Could you please elaborate this? Why do you think this is exotic?

and leads to several issues. I found no other solution than to re-create the table.

Would you describe the issues you faced?

Also, I implemented the one-to-one relation of drink and barcode properly.

What problem are you trying to solve with this change?

Barcode data will be lost upon migration, but I guess we can live with that.

Who is going to re-scan the barcodes? Why not first create the new table, copying data using INSERT INTO ... SELECT FROM ... and then dropping the old table?

[msteinhoff]

Could you please elaborate this? Why do you think this is exotic?

For the record: By convention, RoR ActiveRecord tables always have a integer primary key id column. Re-using this for business values will confuse other developers.

I'd also suggest to re-write the migrations so we dont have to re-import the data:

1. create table barcodes_new
2. copy data from barcodes using INSERT INTO ... SELECT FROM ... (or ruby ORM)
3. drop table barcodes
4. rename table barcodes_new to barcodes

I'd also suggest to validate the barcode value using something like this: https://github.com/hmasing/gtin

[nomaster]

Closing due to inactivity