Add gpuId proc on locale #25943
Merged
Add gpuId proc on locale #25943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
--- Signed-off-by: Andy Stone <[email protected]>
e-kayrakli
approved these changes
Sep 24, 2024
| halt("Can not use 'gpuId' field on a non gpu locale"); | ||
| return -1; | ||
| } | ||
|
|
There was a problem hiding this comment.
There's an unfortunate consequence of adding this here: they are not documented. I believe the locale documentation is in https://chapel-lang.org/docs/main/language/spec/locales.html#locale-methods, and it comes from the record _locale rather than this base implementation class, which is a forwarding field in the record. I believe Jade has recently mentioned that isGpu is also not documented. I believe the same applies for proc gpus.
This is not specific to this PR, and I think we can merge this as is, but could you open an issue about these methods that I think should be documented?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to query gpuID (the location in the parent locale's
here.gpusarray) that a gpu locale is.If used on a non gpu locale it will error out with this message:
Can not use 'gpuId' field on a non gpu localeThis should resolve #23650
TODO: