Fix dyno resolving explicit use of tagged iterators #25995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
dyno-tagged-iter
branch
from
98a17b7
to
7e85854
Compare
riftEmber
changed the title
riftEmber
force-pushed
the
dyno-tagged-iter
branch
from
819da4d
to
e5f8e95
Compare
riftEmber
force-pushed
the
dyno-tagged-iter
branch
2 times, most recently
from
e815089
to
5e63a71
Compare
2 tasks
riftEmber
force-pushed
the
dyno-tagged-iter
branch
4 times, most recently
from
f11fd66
to
1e79196
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
dyno-tagged-iter
branch
from
1e79196
to
813d6f9
Compare
|
Closing as problem is better solved in #26023, which also rolls in the added test case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Dyno to resolve explicit calls to a
tagged iterator variant.This functionality is used in standard modules for iterator forwarding (ChapelDomain example).
Done by pre-empting the usual iterator resolution process, which selects between serial and parallel variants based on how it's used, for the case of an iterator call with a
tagparam.Resolves https://github.com/Cray/chapel-private/issues/6720.
[reviewer info placeholder]
To be merged after #25994 which makes some more significant changes to resolving iterators first.
Testing: