Remove the APU locale model #26001
Merged
Remove the APU locale model #26001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Engin Kayraklioglu <[email protected]>
jabraham17
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APU locale model has been removed and that can't be used. However, we still have the code in the repo. Most importantly, some APU related code is in key modules and creates maintenance burden and confusion at times. This PR removes code related to the APU locale model.
We are still interested in supporting APUs, of course. But that support should be provided via the GPU locale model. The code this PR removes can be good for future reference.
Also resolves https://github.com/Cray/chapel-private/issues/6687
Test: