Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upsert function and accompanying tests #2020

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eakray
Copy link

@eakray eakray commented Sep 8, 2021

Implemented function for polymorphic updating or inserting in one operation

Polymorphic over arrays, objects, and Maps.

Issues:

  • not sure if the style is sufficiently functional
  • not sure if the type signature is correct
  • not quite sure what kind of error handling should be supported
  • not sure how to fill out the @SInCE and @see fields of the jsdoc comment

Please let me know if I can make any improvements to the PR. Thanks.

@eakray eakray closed this Sep 9, 2021
@char0n
Copy link
Owner

char0n commented Sep 13, 2021

Hi @eakray,

Is there a reason you closed this PR? I was going to provide code review during today?

@eakray eakray reopened this Sep 13, 2021
@eakray
Copy link
Author

eakray commented Sep 13, 2021

Hi @eakray,

Is there a reason you closed this PR? I was going to provide code review during today?

Sorry, I mistakenly thought I might not get a response as the original issue is a bit old. Please disregard the closing.

@char0n
Copy link
Owner

char0n commented Sep 17, 2021

@eakray thanks for contributing!

I'll do the review during the weekend. Meanwhile have a look at this model PR: https://github.com/char0n/ramda-adjunct/pull/1480/files

Every new feature need to come with 5 files. See what other files you need to add. I'll help you to get everything ready during the lifetime of this PR.

@char0n
Copy link
Owner

char0n commented Sep 29, 2021

@eakray do you wish to continue with this PR?

@eakray
Copy link
Author

eakray commented Sep 29, 2021

Yes. I’ve been busy recently but plan on pushing some changes this weekend.

@char0n
Copy link
Owner

char0n commented Sep 30, 2021

@eakray sure, no worries, take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants