Merge branch 'master' of github.com:wandersoncferreira/github-review …

…into wip-inline-comments

.github/workflows/ci.yml

@@ -1,11 +1,17 @@
 name: CI
-
-on: [push]
-
+on : [push, pull_request]
 jobs:
   build:
-    runs-on: [ubuntu-latest]
+    runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - name: Run CI in docker
-      run: docker run -v $(pwd):/opt silex/emacs:27.1-ci-cask  bash -c "cd /opt && make ci"
+      - uses: actions/checkout@v1
+      - uses: actions/setup-python@v2
+      - uses: purcell/setup-emacs@master
+        with:
+          version: '27.1'
+      - uses: conao3/setup-cask@master
+        with:
+          version: 'snapshot'
+
+      - name: Run tests
+        run: make test

github-review.el

@@ -374,7 +374,10 @@ ACC is an alist accumulating parsing state."
     (erase-buffer)
     (insert diff)
     (save-buffer)
-    (github-review-mode)))
+    (github-review-mode)
+    ;; Use `C-c C-c' in diff-mode to go to source code
+    (setq default-directory forge-current-dir)
+    (goto-char (point-min))))
 
 (defun github-review-parsed-review-from-current-buffer ()
   "Return a code review given the current buffer containing a diff."
@@ -608,10 +611,15 @@ Github API provides only the originalPosition in the query.")
   (interactive)
   (let* ((pullreq (or (forge-pullreq-at-point) (forge-current-topic)))
          (repo    (forge-get-repository pullreq)))
-    (github-review-start-internal (a-alist 'owner   (oref repo owner)
-                                           'repo    (oref repo name)
-                                           'apihost (oref repo apihost)
-                                           'num     (oref pullreq number)))))
+
+    (if (not (forge-pullreq-p pullreq))
+        (message "We can only review PRs at the moment. You tried on something else.")
+        (progn 
+          (setq forge-current-dir default-directory)  
+          (github-review-start-internal (a-alist  'owner   (oref repo owner)
+                                                  'repo    (oref repo name)
+                                                  'apihost (oref repo apihost)
+                                                  'num     (oref pullreq number)))))))
 
 ;;;###autoload
 (defun github-review-start (url)

makefile

@@ -1,10 +1,7 @@
 .PHONY: ci local test
-ci:
-	cask upgrade-cask
-	cask install
-	cask exec buttercup -L test/github-review-test.el
 
 test:
+	cask install
 	cask exec buttercup -L test/github-review-test.el
 
 # Run the tests locally