Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "setup jsr config" #167

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Revert "setup jsr config" #167

merged 1 commit into from
Mar 10, 2024

Conversation

charkour
Copy link
Owner

Reverts #164

It doesn't work for the following reasons:

error[unsupported-ambient-module]: found an ambient module, which is a global augmentation, which are not unsupported
30 | declare module 'zustand/vanilla' {
   |                ^^^^^^^^^^^^^^^^^
   = hint: remove the ambient module declaration

  info: ambient modules are not supported because they can modify the types of a module from outside of that module
  docs: https://jsr.io/go/slow-type-unsupported-ambient-module

error[unsupported-nested-javascript]: referenced a JavaScript module without type declarations from a TypeScript module
  = hint: add a type declaration (d.ts) for the JavaScript module, or rewrite it to TypeScript

  info: JavaScript files with no corresponding declaration require type inference to be type checked
  info: fast check avoids type inference, so referencing a JavaScript file with no type declarations is not supported
  docs: https://jsr.io/go/slow-type-unsupported-nested-javascript

This package contains errors for slow types. Fixing these errors will:

  1. Significantly improve your package users' type checking performance.
  2. Improve the automatic documentation generation.
  3. Enable automatic .d.ts generation for Node.js.

@charkour charkour merged commit 73f8316 into main Mar 10, 2024
3 checks passed
@charkour charkour deleted the revert-164-jsr branch March 10, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant