Skip to content

Commit

Permalink
Updates based on feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
charles-cowart committed Jul 23, 2024
1 parent d994d89 commit 93a061b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/qiita-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:
jobs:
# derived from https://github.com/actions/example-services/blob/master/.github/workflows/postgres-service.yml
main:
# 7/16/24: confirm current ubuntu-latest is still 22.04.
runs-on: ubuntu-latest

strategy:
Expand Down Expand Up @@ -80,7 +79,7 @@ jobs:
run: |
conda create --yes -n qiita_client python=${{ matrix.python-version }} pip nose flake8 coverage
conda activate qiita_client
pip install .
pip --quiet install .
- name: Starting Main Services
shell: bash -l {0}
Expand Down Expand Up @@ -120,7 +119,6 @@ jobs:
conda activate qiita_client
export QIITA_ROOTCA_CERT=`pwd`/qiita-dev/qiita_core/support_files/ci_rootca.crt
export QIITA_CONFIG_FP=`pwd`/qiita-dev/qiita_core/support_files/config_test_local.cfg
export PYTHONWARNINGS="ignore:Certificate for localhost has no \`subjectAltName\`"
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion qiita_client/qiita_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ def get_job_info(self, job_id):
logger.debug('Entered QiitaClient.get_job_info()')
return self.get("/qiita_db/jobs/%s" % job_id)

def update_job_step(self, job_id, new_step, ignore_error=False):
def update_job_step(self, job_id, new_step, ignore_error=True):
"""Updates the current step of the job in the server
Parameters
Expand Down

0 comments on commit 93a061b

Please sign in to comment.