Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade PW v1.36.1 #29

Merged
merged 5 commits into from
Jul 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,31 +9,33 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
- name: Install dependencies
run: npm ci
- name: Install Playwright
run: npx playwright install --with-deps
- name: Run Playwright tests
run: npx playwright test
env:
API_KEY: ${{ secrets.API_KEY }}
- name: Generate Allure Report
if: always()
run: npm run allure-report
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-test-results
path: test-results/
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: allure-test-results
path: allure-report/
- name: Publish JUnit Report
uses: mikepenz/action-junit-report@v2
uses: mikepenz/action-junit-report@v3
if: always() # always run even if the previous step fails
with:
report_paths: 'junit-results/*.xml'
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ In the `thresholds` section of the [lighthouse.spec.ts](./tests/lighthouse.spec.

If our threshold is 100 for `accessibility`, our test must have 100% acceptance to be considered successful.

```typescript
thresholds: {
performance: 50,
accessibility: 100,
'best-practices': 50,
seo: 50,
pwa: 0,
},
```
```typescript
thresholds: {
performance: 50,
accessibility: 100,
'best-practices': 50,
seo: 50,
pwa: 0,
},
```

#### **To open Playwright's unified Html report of test results**

Expand Down
Loading