(v2) refactor: windows: clean up, tidy and improve windows key handling #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
v2-windows-api
branch
2 times, most recently
from
795bd16
to
c6c153a
Compare
aymanbagabas
changed the title
aymanbagabas
force-pushed
the
v2-exp
branch
3 times, most recently
from
d2bffc5
to
84b68c5
Compare
aymanbagabas
force-pushed
the
v2-windows-api
branch
4 times, most recently
from
d60fcae
to
d61763d
Compare
This fixes a bunch of issues on Windows bringing improvements and reliability to the implementation. It replacing the existing key events hack with a key state that keeps track of previous key events to parse the incoming ANSI escape sequences. It also decodes unicode utf16 pairs at the parser level instead of the driver level. Related: #1126
aymanbagabas
force-pushed
the
v2-windows-api
branch
from
58f5779
to
85d716d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of issues on Windows bringing improvements and reliability to the implementation. It replaces the existing key events hack with a key state that keeps track of previous key events to parse the incoming ANSI escape sequences. It also decodes unicode utf16 pairs at the parser level instead of the driver level.
Related: #1126
TODO: