Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of Contents updates #37

Merged
merged 11 commits into from
Feb 12, 2025
Merged

Conversation

AshleyCliff
Copy link
Contributor

Updates to Table of Contents, organization of how-to sections specifically, and fixing and updating of various references to pages across the docs.

(This is a new PR due to the prior having some problem not showing some updates.)

@AshleyCliff AshleyCliff requested a review from a team as a code owner February 11, 2025 21:14
@AshleyCliff AshleyCliff requested review from NucciTheBoss and removed request for a team February 11, 2025 21:14
@AshleyCliff AshleyCliff added the docs This pull request makes a change to the documentation label Feb 11, 2025
@@ -3,22 +3,23 @@

The guides in this section provide detailed steps for key operations and common tasks for Charmed HPC.

(howto-getstarted)=
## Getting started
- {ref}`howto-initialize-cloud-environment`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a description or context here, but I wasn't sure exactly what/how. Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

The guides in this section provide detailed steps for performing key operations and common tasks in Charmed HPC.

First steps

It is strongly recommend that you go through the {ref}howto-initialize-cloud-environment <Initialize cloud environment> guide first before going through the {ref}Setup section <howto-setup>. This guide will show you how to set up access to the compute, storage, and networking resources your Charmed HPC cluster will need.

We could then add an admonition in the future that is like "first time using/deploying Charmed HPC? Check out these tutorials here" once we have some tutorials added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'll add it. And I agree adding the note pointing to tutorials eventually will help as well.

@NucciTheBoss
Copy link
Member

@AshleyCliff it looks like the Initializing cloud environment how-to is duplicated in the table of contents.

image

Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks real good. Just a couple of suggestions around grammar and landing page content.

@@ -3,22 +3,23 @@

The guides in this section provide detailed steps for key operations and common tasks for Charmed HPC.

(howto-getstarted)=
## Getting started
- {ref}`howto-initialize-cloud-environment`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

The guides in this section provide detailed steps for performing key operations and common tasks in Charmed HPC.

First steps

It is strongly recommend that you go through the {ref}howto-initialize-cloud-environment <Initialize cloud environment> guide first before going through the {ref}Setup section <howto-setup>. This guide will show you how to set up access to the compute, storage, and networking resources your Charmed HPC cluster will need.

We could then add an admonition in the future that is like "first time using/deploying Charmed HPC? Check out these tutorials here" once we have some tutorials added.

@AshleyCliff
Copy link
Contributor Author

Ready for a another look; I think I caught all the capitalization changes.

Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@NucciTheBoss NucciTheBoss merged commit 4479eea into charmed-hpc:main Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This pull request makes a change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants