feat: implement lustre-server-proxy charm #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
force-pushed
the
lustrefs-proxy
branch
from
2c64634 to
7f76663
Compare
NucciTheBoss
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Looking real goo here! Just a couple of minor comments around documentation and code duplication.
We discussed this during our 1:1 that the charm should be renamed from LustreFS to Lustre since Lustre is mounted as mount -t lustre ... rather than mount -t lustrefs ... . Easy search and replace...
charms/filesystem-client/lib/charms/filesystem_client/v0/filesystem_info.py
Outdated
Show resolved
Hide resolved
charms/filesystem-client/lib/charms/filesystem_client/v0/filesystem_info.py
Outdated
Show resolved
Hide resolved
jedel1043
force-pushed
the
lustrefs-proxy
branch
2 times, most recently
from
61568dd to
5980ee0
Compare
jedel1043
force-pushed
the
lustrefs-proxy
branch
from
5980ee0 to
7c4a59c
Compare
jedel1043
force-pushed
the
lustrefs-proxy
branch
from
7c4a59c to
09c0344
Compare
NucciTheBoss
approved these changes
Jan 16, 2025
NucciTheBoss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No integration tests yet, since we'll need to implement the required parts on
filesystem-client. That's also why this doesn't enable publishing it to Charmhub.