-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate repository to a monorepo #8
Conversation
Notes: * This config.yaml supports setting the NFS share endpoint that will be retrieved by NFS clients.
…igure Configure Renovate
…novate/canonical-charming-actions-2.x chore(deps): update canonical/charming-actions action to v2.3.0
Adjusts tests to the newer client.
Adjusts tests to the newer client.
…harmhub token Adds `.charmhub.secret` to `.gitignore` to avoid accidentally commiting sensitive secrets.
Signed-off-by: Jason C. Nucciarone <[email protected]>
`pyright` only looks at the src/ directory. Signed-off-by: Jason C. Nucciarone <[email protected]>
…rver-proxy/main' into 'main'
c630087
to
45a6ebf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments before merging
Hmm, I'm testing the rebase merge against my fork and it seems that it also isn't applied correctly. I'll have to rewrite the main branch manually. It shouldn't be that bad though, it's just a manual push instead of an automatic one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not merging since you need to merge manually.
This consolidates the charms:
into a single repository, which should make it easier to maintain and test.
Obviously the history will look massive in the PR, but the last 7 commits are the main sauce of it, so you can filter for that when trying to review the code.
Also, when merging this do NOT squash, or else all the history will be lost and we'll have to rewrite everything again. Just rebase and merge.Rebase and merge also doesn't work. It'll have to be a manual push.