Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type string in ingress service port and pathType in ingress path #37

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mike7515
Copy link

@mike7515 mike7515 commented Feb 16, 2022

Support type string in ingress service port and pathType in ingress path to work with Application Load Balancer.

It is required to support the ssl-redirect and a different pathType (ex. "Prefix"):

spec:
  rules:
  - host: chartmuseum.domain.com
    http:
      paths:
      - path: "/"
        backend:
          service:
            name: ssl-redirect
            port:
              name: use-annotation
        pathType: "Prefix"

@mike7515 mike7515 changed the title Support string type in ingress service port and pathType in ingress path Support type string in ingress service port and pathType in ingress path Feb 16, 2022
@cbuto
Copy link
Collaborator

cbuto commented Feb 17, 2022

thanks for the PR @mike7515! It looks a similar change is being worked in #35 and #36 by @b0nete.

@cbuto
Copy link
Collaborator

cbuto commented Apr 5, 2022

@mike7515 PR #35 has been merged. You can rebase with main and add the additional changes regarding port number vs name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants