List dirs #56
Open
List dirs #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Interface methods
won't work until we add ListFolders to the Backend interface
This reverts commit fe3b508.
alice-sawatzky
force-pushed
the
list-dirs
branch
from
42f6c50 to
2b4d04f
Compare
|
I've rebased to the latest |
|
hello! I've been on leave, just coming back, is there any interest in moving forward with this feature? I realize I left this hanging for a long time, but the conflicts look pretty manageable considering how long it's been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ListFolders()function to all storage modules. Refactor modules to use an iterator to reduce redundant code betweenListObjects()andListFolders().The goal is to support a chartmuseum endpoint described in helm/chartmuseum#360.
This is my first contribution to a Go project so feedback and patience is appreciated!
Progress:
[x] alibaba
[x] amazon
[x] baidu
[x] etcd
[x] google
[x] local
[x] microsoft
[x] netease
[x] openstack
[x] oracle
[x] tencent
[x] update Backend interface
[x] beef up tests a bit