Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite with typescript #2

Merged
merged 1 commit into from
Dec 23, 2023
Merged

rewrite with typescript #2

merged 1 commit into from
Dec 23, 2023

Conversation

farmer00317558
Copy link
Contributor

Bun treats TypeScript as a first-class citizen, so I rewrite chdb-bun with TypeScript.

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lmangani
Copy link
Contributor

lmangani commented Dec 23, 2023 •
edited
Loading

Thanks for the contribution! We just need to patch the action to use example.ts for validating the build.

@lmangani
Copy link
Contributor

@farmer00317558 i fixed the build and test, but the action fails validation

@lmangani lmangani self-requested a review December 23, 2023 13:59
lmangani
lmangani suggested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@lmangani lmangani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the build test action passes successfully

@farmer00317558 farmer00317558 force-pushed the main branch 2 times, most recently from 7fee87d to eda73fb Compare December 23, 2023 14:20
@lmangani lmangani self-requested a review December 23, 2023 14:37
@lmangani lmangani merged commit c7d23ac into chdb-io:main Dec 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmangani lmangani lmangani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farmer00317558 @CLAassistant @lmangani