Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chdb v3.0 Connect method #16

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

agoncear-mwb
Copy link
Contributor

This pr implements the new statefull session created in the v3.0.0 release.

For backward compatibility, at the moment, i kept the old session mechanism still avaiable, but i guess in future release we can remove it in favor of the new ChdbConnection which is equivalent in methods but handle the connection with the underlying clickhouse local in a better way.

@auxten
Copy link
Member

auxten commented Jan 30, 2025

The old impl of query and the new one can not co-exist in one process.
As the new one need to keep some global stuff, but the old one tend to cleanup everything on finished.

@auxten
Copy link
Member

auxten commented Feb 3, 2025

@agoncear-mwb are you still working on this?

We should use the Connection base queryConn here instead.
And the Query should also use the the Connection base queryConn
See also: https://github.com/chdb-io/chdb/blob/d26d2ce84190e9f9e2dbbde024ac09e9739198eb/chdb/__init__.py#L75

@agoncear-mwb
Copy link
Contributor Author

ok, so we should remove the old one?
I'll have a double check today, and push the mods ASAP

@auxten
Copy link
Member

auxten commented Feb 3, 2025

We need to try our best to keep the user side API stable, so the plan is:

@agoncear-mwb
Copy link
Contributor Author

Perfect, i'll try to keep the implementation as close as possible with the python binding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants