Fix failed test #46
Merged
Fix failed test #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
dkwon17
reviewed
Nov 23, 2023
| assertEquals("Apple pie", foods[1].name); | ||
| assertEquals("Strawberry cake", foods[2].name); | ||
| assertEquals("Sandwich", foods[3].name); | ||
| assertEquals("Soup", foods[4].name); |
There was a problem hiding this comment.
Thank you @svor I'm not sure why the order changed causing the failure on main
Maybe instead, we can sort by name instead of id for the list endpoint?
return Food.listAll(Sort.by("name"));
There was a problem hiding this comment.
@dkwon17 makes sense, updated
Signed-off-by: Valeriy Svydenko <[email protected]>
dkwon17
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem:
Run Tests command is failed:
After the fix:
