feat: add assertion and connection error reporters to TCP checks [sc-23082] #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorccu
force-pushed
the
simokinnunen/sc-23082/fix-cli-tcp-check-assertion-reporters
branch
from
a9e1499 to
1c9e281
Compare
sorccu
deleted the
simokinnunen/sc-23082/fix-cli-tcp-check-assertion-reporters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds reporter support for TCP check assertion and connection errors.
I added a new fixture folder with TCP checks that at least currently are able to trigger various error scenarios. However, I am undecided as to whether such checks are stable enough to use in e2e checks, so the fixtures are currently unused.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission