Codegen guide #1224
Merged
Codegen guide #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stefanjudis
reviewed
Feb 21, 2025
stefanjudis
reviewed
Feb 21, 2025
|
|
||
| ### Step 5: Add Assertions to your tests | ||
|
|
||
| Every action in the script above has implicit assertions about the elements we interact with. Playwright will expect these elements are stable, visible, and enabled and if one isn’t then the test will will fail we could call this done, but we generally want our tests to contain assertions beyond just navigating. There are a few reasons why you should have assertions in your test: It makes it clearer to future coders what your test was checking for, and the error message is more useful from a failed assertion rather than just failing to find an element. Right now all we’ll get if the test above fails is a timeout and a line which failed. |
There was a problem hiding this comment.
It makes it clearer to future coders what your test was checking for, and the error message is more useful from a failed assertion rather than just failing to find an element. Right now all we’ll get if the test above fails is a timeout and a line which failed.
A comparison screenshot showing the failed actionability check and a failed assertion would be great to hit this point home.
There was a problem hiding this comment.
working on this, I'm struggling a bit to make a nice readable screenshot, so will push v1 without it but it will be something I'll add next week.
stefanjudis
reviewed
Feb 21, 2025
stefanjudis
reviewed
Feb 21, 2025
Co-authored-by: Stefan Judis <[email protected]>
Co-authored-by: Stefan Judis <[email protected]>
Dgiordano33
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components