Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent fetching pool transactions every tick #284

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Apr 2, 2024

Currently we fetch receipt of each transaction that is in pending block on every tick, even if we already saw this transaction before.

This is causing lots of requests as block can have ~400 transactions sitting in it for minutes and we hit it every 2 seconds.

Now instead of fetching those and skipping this in handlePool we skip those before they are even fetched.

Currently we fetch receipt of each transaction that is in pending block
on every tick, even if we already saw this transaction before.

This is causing lots of requests as block can have ~400 transactions
sitting in it for minutes and we hit it every 2 seconds.

Now instead of fetching those and skipping this in handlePool we skip
those before they are even fetched.
@Sekhmet Sekhmet requested a review from bonustrack April 2, 2024 15:17
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 🤑

@Sekhmet Sekhmet merged commit 88838a6 into master Apr 2, 2024
1 check passed
@Sekhmet Sekhmet deleted the sekhmet/prevent-pool-fetch branch April 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants