memparse: add search functionality to memparse #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snprajwal
reviewed
Jul 21, 2024
snprajwal
reviewed
Jul 21, 2024
behouba
force-pushed
the
search-memory-pages
branch
from
3c8779b
to
68a6faf
Compare
snprajwal
reviewed
Jul 22, 2024
behouba
force-pushed
the
search-memory-pages
branch
from
68a6faf
to
04dec1a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 78.73% 81.50% +2.77%
==========================================
Files 11 11
Lines 1260 1060 -200
==========================================
- Hits 992 864 -128
+ Misses 201 126 -75
- Partials 67 70 +3 ☔ View full report in Codecov by Sentry. |
behouba
force-pushed
the
search-memory-pages
branch
from
04dec1a
to
6011f85
Compare
rst0git
changed the title
behouba
force-pushed
the
search-memory-pages
branch
2 times, most recently
from
694ce19
to
5b6e6b2
Compare
rst0git
reviewed
Jul 26, 2024
behouba
force-pushed
the
search-memory-pages
branch
from
5b6e6b2
to
d3be9c5
Compare
|
Hi @behouba! If you feel the changes on go-criu are ready, we can make a new release of the library and update this PR. What do you think? |
|
Hi @snprajwal! I think we’re ready for a new release of go-criu. I’ve been testing the new feature on various checkpoints, and everything seems to be working well so far. Let’s proceed with a new release of the library ) |
Signed-off-by: Kouame Behouba Manasse <[email protected]>
This commit adds `--search`, `--search-regex` and `--context` flags to `memparse`, enabling pattern search in a process's memory pages. Signed-off-by: Kouame Behouba Manasse <[email protected]>
behouba
force-pushed
the
search-memory-pages
branch
from
d3be9c5
to
53a0c25
Compare
…lags in `memparse` Signed-off-by: Kouame Behouba Manasse <[email protected]>
behouba
force-pushed
the
search-memory-pages
branch
from
53a0c25
to
c5c2f1e
Compare
snprajwal
approved these changes
Sep 16, 2024
|
@rst0git PTAL |
rst0git
reviewed
Sep 23, 2024
…mparse man page. Signed-off-by: Kouame Behouba Manasse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is intended to help evaluate the performance of #163. It introduces
--searchand--contextflags tomemparse, enabling pattern searches within a process's memory pages.Example usage: