use habitat build instead of omnibus #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
Signed-off-by: rishichawda <[email protected]>
rishichawda
force-pushed
the
rishichawda/use-habitat-builds
branch
from
4a6d74c to
3f54696
Compare
|
|
||
| CHEFDK_APPS = [ | ||
| HABITAT_PACKAGES = [ | ||
| App.new( |
There was a problem hiding this comment.
I believe we're using chef/berkshelf for the remnant of this usage.
There was a problem hiding this comment.
updated the origin to chef in 6ee4d26. Updated the origin for other packages as well.
bin/appbundle-updater
Outdated
| @@ -154,7 +175,7 @@ CHEFDK_APPS = [ | |||
| "chef-dk", | |||
There was a problem hiding this comment.
I think we can remove chef-dk
| ), | ||
| App.new( | ||
| "cookstyle", | ||
| "chef/cookstyle", | ||
| "development debug docs", | ||
| "#{bin_dir.join("rake")} install" | ||
| "#{vendor_bin_dir.join("rake")} install" | ||
| ), | ||
| App.new( |
There was a problem hiding this comment.
We can remove foodcritic
11 tasks
Signed-off-by: rishichawda <[email protected]>
remove chef-dk and foodcritic(https://github.com/chef/appbundle-updater/pull/107#discussion_r1935980449,https://github.com/chef/appbundle-updater/pull/107#discussion_r1935981464). updated the origins for remaining packages. Signed-off-by: rishichawda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chef19 is now habitat based package.
appbundle-updateris used in kitchen test pipelines under Github actions of chef/chef to do en-to-end recipe testing of chef so that current code inside a PR also gets tested each time a commit is pushed. Since previous versions of Chef used to be omnibus packages, implementation ofappbundle-updateris based upon omnibus installation details.In this PR we make this tool habitat compliant.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.