code review changes.

Signed-off-by: talktovikas <[email protected]>
chef · Dec 12, 2024 · 42bdf59 · 42bdf59
1 parent e624bf0
commit 42bdf59
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/omnibus/files/server-ctl-cookbooks/infra-server/templates/default/oc_erchef.config.erb b/omnibus/files/server-ctl-cookbooks/infra-server/templates/default/oc_erchef.config.erb
@@ -194,7 +194,7 @@
             {timeout, <%= @solr_timeout %>},
             {init_count, <%= @solr_http_init_count %>},
             {max_count, <%= @solr_http_max_count %>},
-            {track_total_hits,true},
+            {track_total_hits, <%= @solr_track_total_hits %>},
             {cull_interval, <%= @solr_http_cull_interval %>},
             {max_age, <%= @solr_http_max_age %>},
             {max_connection_duration, <%= @solr_http_max_connection_duration %>},

diff --git a/src/oc_erchef/apps/chef_index/src/chef_index_query.erl b/src/oc_erchef/apps/chef_index/src/chef_index_query.erl
@@ -30,7 +30,7 @@ from_params(Provider, ObjType, QueryString, Start, Rows) ->
                      search_provider = Provider,
                      start = decode({nonneg_int, "start"}, Start, 0),
                      rows = decode({nonneg_int, "rows"}, Rows, 1000),
-                     track_total_hits = envy:get(chef_index, track_total_hits, true, boolean),
+                     track_total_hits = envy:get(chef_index, track_total_hits, false, boolean),
                      sort = "X_CHEF_id_CHEF_X asc",
                      index = index_type(ObjType)}.
 

diff --git a/src/oc_erchef/apps/chef_index/test/chef_index_query_tests.erl b/src/oc_erchef/apps/chef_index/test/chef_index_query_tests.erl
@@ -40,7 +40,7 @@ query_from_params_test_() ->
             sort = "X_CHEF_id_CHEF_X asc",
             start = 2,
             rows = 5,
-            track_total_hits=true,
+            track_total_hits=false,
             index = node},
           ?assertEqual(Expect, Query)
       end},
@@ -58,7 +58,7 @@ query_from_params_test_() ->
             sort = "X_CHEF_id_CHEF_X asc",
             start = 0,
             rows = 1000,
-            track_total_hits=true,
+            track_total_hits=false,
             index = role},
           ?assertEqual(Expect, Query)
       end},