Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate class for core EMLE functionality #28

Closed
wants to merge 24 commits into from

Conversation

kzinovjev
Copy link
Contributor

The basis for implementing training and error analysis scripts as an integral part of emle-engine. The EMLEBase class provides predictions for valence shell widths, core charges, valence charges, and the 3Nx3N A matrix from the Thole model. It also accepts (padded) batches of coordinates and atomic numbers, instead of a single molecule, which will be necessary for training. The code responsible for calculating the interaction with MM point charges (and therefore not relevant for training) is kept in the EMLE class.

Minor changes:

  • There was a subtle bug in how the coefficients for GPR were calculated. This has now been fixed, so the numeric tests will most likely fail. However, I compared the predictions with those from the (JAX-based) training code, and they are identical.
  • The alpha_mode='reference' model has been redefined such that the full k is calculated as the product of k_Z and an additional scaling factor. This effectively makes the reference (GPR-based) polarizability model a correction to the species model: if the correction factor is not applied, the species model is recovered. This allows to keep only one default model instead of two separate ones.

@lohedges lohedges mentioned this pull request Oct 22, 2024
@lohedges lohedges closed this in #29 Oct 22, 2024
@lohedges lohedges added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants